SILGen: Emit copy x on a trivial value as a trivial copy.
#80773
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
This was referenced Apr 11, 2025
Avoids an assertion failure emitting an `explicit_copy_value` on the trivial value, which is unsupported. This allows `copy x` to compile, albeit with no effect (which is not ideal, but also not a regression, since no-implicit-copy controls still don't fully work on trivial values). Fixes swiftlang#80573 and rdar://148712387.
jckarter
force-pushed
the
trivial-copy-operator
branch
from
c5188e5 to
8dac2b1
Compare
|
@swift-ci Please test |
|
@swift-ci Please test Linux |
|
@swift-ci Please test macOS |
1 similar comment
|
@swift-ci Please test macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoids an assertion failure emitting an
explicit_copy_valueon the trivial value, which is unsupported. This allowscopy xto compile, albeit with no effect (which is not ideal, but also not a regression, since no-implicit-copy controls still don't fully work on trivial values). Fixes #80573 and rdar://148712387.